fix: parser for azureeventhubs message without time field #1990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wildum
reviewed
Oct 29, 2024
wildum
approved these changes
Oct 29, 2024
Co-authored-by: William Dumont <[email protected]>
|
Sorry one more thing before merging: at the top of the parser file there is a comment saying that the code is copied from Loki with a ref to the version. I see that now the fix has been merged in loki, could you update the ref of the commit to match the current state in Loki please? |
Sure 👍 I have updated a link to: This commit contains the same fix and was recently merged into the Loki project. |
wildum
deleted the
andrii/fix-event-hub-log-message-parsing-without-time-field
branch
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR is fixing the same bug described for the Loki project in:
The Azure Event Hubs messages parser ignores records that don't contain the
timefield.timeStampfield instead.Which issue(s) this PR fixes
Related to:
Notes to the Reviewer
PR Checklist